Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General coding standard check #351

Merged
merged 16 commits into from
Nov 13, 2023
Merged

General coding standard check #351

merged 16 commits into from
Nov 13, 2023

Conversation

ziyi105
Copy link

@ziyi105 ziyi105 commented Nov 13, 2023 •
edited
Loading

Fixes #346

DextheChik3n
DextheChik3n reviewed Nov 13, 2023
View reviewed changes
Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments on some small suggested changes

src/main/java/seedu/cafectrl/data/CurrentDate.java Outdated Show resolved Hide resolved
src/main/java/seedu/cafectrl/data/dish/Ingredient.java Outdated Show resolved Hide resolved
DextheChik3n
DextheChik3n approved these changes Nov 13, 2023
View reviewed changes
Copy link

@DextheChik3n DextheChik3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on ensuring the spacing between processes to ensure clarity in code and replacing magic numbers.

@ziyi105 ziyi105 merged commit 4abbf3f into AY2324S1-CS2113-T17-2:master Nov 13, 2023
3 checks passed
ShaniceTang
ShaniceTang reviewed Nov 13, 2023
View reviewed changes
Copy link

@ShaniceTang ShaniceTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaniceTang ShaniceTang ShaniceTang left review comments

@DextheChik3n DextheChik3n DextheChik3n approved these changes

@NaychiMin NaychiMin Awaiting requested review from NaychiMin

@Cazh1 Cazh1 Awaiting requested review from Cazh1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text file syntax reminder output format
3 participants
@ziyi105 @DextheChik3n @ShaniceTang